Re: [PATCHv2] regulator: cpcap: Add basic regulator support

From: Rob Herring
Date: Mon Feb 06 2017 - 16:27:11 EST


On Thu, Feb 2, 2017 at 5:43 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> Many Motorola phones like droid 4 are using a custom PMIC called CPCAP
> or 6556002. This PMIC is used with several SoCs, I've noticed at least
> omap3, omap4 and Tegra2 based Motorola phones and tablets using it.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Marcel Partap <mpartap@xxxxxxx>
> Cc: Michael Scott <michael.scott@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
>
> With the cpcap core MFD driver now in Linux next as commit
> 3d66c8abc13e ("mfd: cpcap: Add minimal support"), here's a related
> regulator driver. This is needed to support more devices on droid 4,
> such as the LCD and touchscreen.
>
> Changes since v1:
>
> - Use standard regulator sel_regmap functions and drop the pointless
> custom implementations as commented by Mark Brown
>
> - Fix unit-address with no reg property as commented by Rob Herring
>
> ---
> .../bindings/regulator/cpcap-regulator.txt | 34 ++

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/regulator/Kconfig | 7 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/cpcap-regulator.c | 464 +++++++++++++++++++++
> 4 files changed, 506 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/cpcap-regulator.txt
> create mode 100644 drivers/regulator/cpcap-regulator.c