Re: [PATCH 1/3] kprobes: introduce weak variant of kprobe_exceptions_notify

From: Masami Hiramatsu
Date: Tue Feb 07 2017 - 20:54:48 EST


On Wed, 8 Feb 2017 01:24:14 +0530
"Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:

> kprobe_exceptions_notify() is not used on some of the architectures such
> as arm[64] and powerpc anymore. Introduce a weak variant for such
> architectures.
>

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

for all patches in this series.

Thank you!

> Signed-off-by: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
> ---
> kernel/kprobes.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 43460104f119..60a702a05684 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1705,6 +1705,12 @@ void unregister_kprobes(struct kprobe **kps, int num)
> }
> EXPORT_SYMBOL_GPL(unregister_kprobes);
>
> +int __weak __kprobes kprobe_exceptions_notify(struct notifier_block *self,
> + unsigned long val, void *data)
> +{
> + return NOTIFY_DONE;
> +}
> +
> static struct notifier_block kprobe_exceptions_nb = {
> .notifier_call = kprobe_exceptions_notify,
> .priority = 0x7fffffff /* we need to be notified first */
> --
> 2.11.0
>


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>