Re: mm: testcases for RODATA: renamed Kconfig option

From: Valentin Rothberg
Date: Wed Feb 08 2017 - 05:58:48 EST


Hi Jinbum,

On Wed, Feb 8, 2017 at 11:44 AM, park jinbum <jinb.park7@xxxxxxxxx> wrote:
>
> Thanks for your supporting!!
>
> If you send a trivial patch to me, What should I do next??
>
> Test it, and send final patch again??

Feel free to prepare the patch yourself, if you want to. Then it's
the usual pipeline of testing your commit, running checkpatch.pl and
so on. After you send it to the maintainer(s) and they will take care
of it. Just as you did before.

Best regards,
Valentin

> I'm not familiar with situation like this . . because I'm a kernel
> newbie...
>
> Thanks.
> Jinbum Park.
>
>
> 2017. 2. 8. ìí 6:34ì "Valentin Rothberg" <valentinrothberg@xxxxxxxxx>ëì ìì:
>
> Hi Jinbum,
>
> your commit bf9058f08772 ("mm: add arch-independent testcases for
> RODATA") has shown up in today's linux next and ran into an issue with
> another commit.
>
> The added testcases depend on DEBUG_RODATA_TEST, which further depends
> on DEBUG_RODATA. DEBUG_RODATA, however, has been renamed to
> STRICT_KERNEL_RWX by commit 0f5bf6d0afe4 ("arch: Rename
> CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX").
>
> Long story short. DEBUG_RODATA_TEST is currently dead, since
> DEBUG_RODATA doesn't exist anymore. If you want to, I can send a
> trivial patch that renames the dependency and renames
> DEBUG_RODATA_TEST to STRICT_KERNEL_RWX_TEST to keep consistency.
>
> I detected the issue with scripts/checkkconfigsymbols.py.
>
> Kind regards,
> Valentin
>
>