Re: [PATCH v2 06/16] net: stmmac: fix some code style problem

[Sergei Shtylyov]

Hello!

On 2/8/2017 11:31 AM, Corentin Labbe wrote:

> Checkpatch complains about some code style problem on stmmac_mdio.c.
> This patch fix them.

   Fixes.

> Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index 3fdc6ec..c24bef2 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
[...]
> @@ -267,7 +268,7 @@ int stmmac_mdio_register(struct net_device *ndev)
>  			 * If an IRQ was provided to be assigned after
>  			 * the bus probe, do it here.
>  			 */
> -			if ((mdio_bus_data->irqs == NULL) &&
> +			if ((!mdio_bus_data->irqs) &&

   Innermost parens not needed (and weren't needed before).

>  			    (mdio_bus_data->probed_phy_irq > 0)) {
>  				new_bus->irq[addr] =
>  					mdio_bus_data->probed_phy_irq;

MBR, Sergei