Re: IB/hfi1: Use memdup_user() rather than duplicating its implementation in hfi1_user_sdma_process_request()
From: SF Markus Elfring
Date: Mon Feb 13 2017 - 06:13:23 EST
>> Thanks for the patch, but this one is already taken care of along
>> with other similar uses of kmalloc/copy:
> Michael's patch doesn't change user_sdma_free_request() so it introduces
> a kfreeing an error pointer bug.
Did you notice that another local variable “tmp” was introduced in the update step
“[PATCH 27/27] IB/hfi1: Code reuse with memdup_copy” so that
the mentioned function will usually get a null pointer after a failure there?