Re: IB/hfi1: Use memdup_user() rather than duplicating its implementation in hfi1_user_sdma_process_request()
From: Dan Carpenter
Date: Mon Feb 13 2017 - 09:02:37 EST
On Mon, Feb 13, 2017 at 12:12:51PM +0100, SF Markus Elfring wrote:
> >> Thanks for the patch, but this one is already taken care of along
> >> with other similar uses of kmalloc/copy:
> >> http://marc.info/?l=linux-rdma&m=148656088729538&w=2
> > Michael's patch doesn't change user_sdma_free_request() so it introduces
> > a kfreeing an error pointer bug.
> Did you notice that another local variable âtmpâ was introduced in the update step
> â[PATCH 27/27] IB/hfi1: Code reuse with memdup_copyâ so that
> the mentioned function will usually get a null pointer after a failure there?
Ah right. Thanks. I missed that.