Re: [PATCH RFC 1/3] coresight: binding for coresight debug driver
From: Mark Rutland
Date: Wed Feb 15 2017 - 06:14:01 EST
On Mon, Feb 13, 2017 at 02:11:36PM +0800, Leo Yan wrote:
> Adding compatible string for new coresight debug driver.
Please give a more thorough description of the hardware this binding
this is intended to describe.
It's not entirely clear which component this binding is intended to
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> Documentation/devicetree/bindings/arm/coresight.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index fcbae6a..3ff15fd 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -40,6 +40,9 @@ its hardware characteristcs.
> - System Trace Macrocell:
> "arm,coresight-stm", "arm,primecell"; 
> + - Debug Unit:
> + "arm,coresight-debug", "arm,primecell";
> * reg: physical base address and length of the register
> set(s) of the component.
> @@ -78,8 +81,10 @@ its hardware characteristcs.
> * arm,cp14: must be present if the system accesses ETM/PTM management
> registers via co-processor 14.
> - * cpu: the cpu phandle this ETM/PTM is affined to. When omitted the
> - source is considered to belong to CPU0.
> +* Optional properties for ETM/PTM/Debugs:
> + * cpu: the cpu phandle this ETM/PTM/Debug is affined to. When omitted
> + the source is considered to belong to CPU0.
> * Optional property for TMC: