Re: [PATCH] gpio: xgene: mark PM functions as __maybe_unused

From: Arnd Bergmann
Date: Wed Feb 15 2017 - 16:35:47 EST

On Tue, Feb 14, 2017 at 10:20 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions:
> drivers/gpio/gpio-xgene.c:155:12: warning: 'xgene_gpio_resume' defined but not used [-Wunused-function]
> static int xgene_gpio_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-xgene.c:142:12: warning: 'xgene_gpio_suspend' defined but not used [-Wunused-function]
> static int xgene_gpio_suspend(struct device *dev)
> The warnings are harmless and can be avoided by simplifying the code and marking
> the functions as __maybe_unused.
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

I ran into a problem with this version, please either add this trivial fixup:

diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index 1fd62bef562b..f1c6ec17b90a 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -42,9 +42,7 @@ struct xgene_gpio {
struct gpio_chip chip;
void __iomem *base;
spinlock_t lock;
-#ifdef CONFIG_PM
u32 set_dr_val[XGENE_MAX_GPIO_BANKS];

static int xgene_gpio_get(struct gpio_chip *gc, unsigned int offset)

or wait for a new version from me.