Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed.

From: Julia Lawall
Date: Mon Feb 20 2017 - 03:48:50 EST

Next message: Dou Liyang: "[PATCH v2 0/4] Revert works for the mapping of cpuid <-> nodeid"
Previous message: Steve Twiss: "RE: [RESEND PATCH V5 7/8] thermal: da9062/61: Thermal junction temperature monitoring driver"
In reply to: Julia Lawall: "Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 19 Feb 2017, Arushi Singhal wrote:

>
>
> On Monday, February 20, 2017 at 12:32:22 PM UTC+5:30, Julia Lawall wrote:
>
>
> On Mon, 20 Feb 2017, Arushi Singhal wrote:
>
> > Unnecessary parentheses should be avoided as reported by
> checkpatch.pl.
> > Remove unnecessary parentheses, as reported by checkpatch as
> are nicer
> > to read.For example:-
> > It's often nicer to read if &(foo[0]) is converted to foo
> like:
> > Â Â Âmemcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
> > Â Â Âmemcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
>
> The commit message is not well presented. ÂOne has the
> impression that all
> of the changes are related to 0 array elements. ÂIt would be
> better to
> split the patch into two: one for removing parentheses, and one
> for making
> the &x[0] -> x change. ÂThey don't really have anything to do
> with each
> other.
>
> julia
>
>
>
> Hi
> So should I change the commit message to more appropriate one so that it
> better explain the changes?

Yes please. Remember to put v2 in the subject line and to explain the
change you made under the ---

julia

>
>
> >
> > Signed-off-by: Arushi Singhal <arushising...@xxxxxxxxx>
> > ---
> > Âdrivers/staging/ks7010/ks_hostif.c Â | 20
> ++++++++++----------
> > Âdrivers/staging/ks7010/ks_wlan_net.c | 20
> ++++++++++----------
> > Â2 files changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/staging/ks7010/ks_hostif.c
> b/drivers/staging/ks7010/ks_hostif.c
> > index ba283ab741a7..2d5ec57c5cfd 100644
> > --- a/drivers/staging/ks7010/ks_hostif.c
> > +++ b/drivers/staging/ks7010/ks_hostif.c
> > @@ -239,19 +239,19 @@ int get_ap_information(struct
> ks_wlan_private *priv, struct ap_info_t *ap_info,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ*(bp + 1));
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂap->ssid.size =
> SSID_MAX_SIZE;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(&(ap->ssid.body[0]), bp + 2,
> ap->ssid.size);
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(ap->ssid.body, bp + 2,
> ap->ssid.size);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂbreak;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcase 1:ÂÂÂÂÂÂÂÂ/* rate */
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcase 50:ÂÂÂÂÂÂÂÂ/* ext rate */
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif ((*(bp + 1) + ap->rate_set.size)
> <=
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â ÂRATE_SET_MAX_SIZE) {
> >-ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(&(ap->rate_set.body[ap->rate_set.si
> ze]),
> >+ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(&ap->rate_set.body[ap->rate_set.siz
> e],
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â Â bp + 2, *(bp + 1));
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂap->rate_set.size += *(bp +
> 1);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ} else {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂDPRINTK(1, "size over :: rate
> size=%d\n",
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ(*(bp + 1) +
> ap->rate_set.size));
> >-ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(&(ap->rate_set.body[ap->rate_set.si
> ze]),
> >+ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(&ap->rate_set.body[ap->rate_set.siz
> e],
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â Â bp + 2,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â Â RATE_SET_MAX_SIZE -
> ap->rate_set.size);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂap->rate_set.size +=
> > @@ -269,7 +269,7 @@ int get_ap_information(struct
> ks_wlan_private *priv, struct ap_info_t *ap_info,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ*(bp + 1));
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂap->rsn_ie.size =
> RSN_IE_BODY_MAX;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(&(ap->rsn_ie.body[0]), bp + 2,
> ap->rsn_ie.size);
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(ap->rsn_ie.body, bp + 2,
> ap->rsn_ie.size);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂbreak;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcase 221:ÂÂÂÂÂÂÂÂ/* WPA */
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (!memcmp(bp + 2,
> "\x00\x50\xf2\x01", 4)) {ÂÂÂÂÂÂÂÂ/* WPA OUI check */
> > @@ -282,7 +282,7 @@ int get_ap_information(struct
> ks_wlan_private *priv, struct ap_info_t *ap_info,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ*(bp + 1));
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂap->wpa_ie.size =
> RSN_IE_BODY_MAX;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(&(ap->wpa_ie.body[0]),
> bp + 2,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(ap->wpa_ie.body, bp +
> 2,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â Â ap->wpa_ie.size);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂbreak;
> > @@ -832,8 +832,8 @@ void hostif_scan_indication(struct
> ks_wlan_private *priv)
> > ÂÂÂÂÂÂÂÂÂif (priv->scan_ind_count != 0) {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfor (i = 0; i < priv->aplist.size; i++)
> {ÂÂÂÂÂÂÂÂ/* bssid check */
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (!memcmp
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â(&(ap_info->bssid[0]),
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â &(priv->aplist.ap[i].bssid[0]),
> ETH_ALEN)) {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â(ap_info->bssid,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â &priv->aplist.ap[i].bssid[0],
> ETH_ALEN)) {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (ap_info->frame_type ==
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â ÂFRAME_TYPE_PROBE_RESP)
> >
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂget_ap_information(priv,
> ap_info,
> > @@ -2652,7 +2652,7 @@ int hostif_init(struct ks_wlan_private
> *priv)
> >
> > ÂÂÂÂÂÂÂÂÂpriv->aplist.size = 0;
> > ÂÂÂÂÂÂÂÂÂfor (i = 0; i < LOCAL_APLIST_MAX; i++)
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemset(&(priv->aplist.ap[i]), 0,
> sizeof(struct local_ap_t));
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemset(&priv->aplist.ap[i], 0, sizeof(struct
> local_ap_t));
> > ÂÂÂÂÂÂÂÂÂpriv->infra_status = 0;
> > ÂÂÂÂÂÂÂÂÂpriv->current_rate = 4;
> > ÂÂÂÂÂÂÂÂÂpriv->connect_status = DISCONNECT_STATUS;
> > @@ -2675,12 +2675,12 @@ int hostif_init(struct ks_wlan_private
> *priv)
> > ÂÂÂÂÂÂÂÂÂINIT_WORK(&priv->ks_wlan_wakeup_task,
> ks_wlan_hw_wakeup_task);
> >
> > ÂÂÂÂÂÂÂÂÂ/* WPA */
> > -ÂÂÂÂÂÂÂÂmemset(&(priv->wpa), 0, sizeof(priv->wpa));
> > +ÂÂÂÂÂÂÂÂmemset(&priv->wpa, 0, sizeof(priv->wpa));
> > ÂÂÂÂÂÂÂÂÂpriv->wpa.rsn_enabled = 0;
> > ÂÂÂÂÂÂÂÂÂpriv->wpa.mic_failure.failure = 0;
> > ÂÂÂÂÂÂÂÂÂpriv->wpa.mic_failure.last_failure_time = 0;
> > ÂÂÂÂÂÂÂÂÂpriv->wpa.mic_failure.stop = 0;
> > -ÂÂÂÂÂÂÂÂmemset(&(priv->pmklist), 0, sizeof(priv->pmklist));
> > +ÂÂÂÂÂÂÂÂmemset(&priv->pmklist, 0, sizeof(priv->pmklist));
> > ÂÂÂÂÂÂÂÂÂINIT_LIST_HEAD(&priv->pmklist.head);
> > ÂÂÂÂÂÂÂÂÂfor (i = 0; i < PMK_LIST_MAX; i++)
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂINIT_LIST_HEAD(&priv->pmklist.pmk[i].list);
> > diff --git a/drivers/staging/ks7010/ks_wlan_net.c
> b/drivers/staging/ks7010/ks_wlan_net.c
> > index 8c55428b71c7..9f4bd7c3ea12 100644
> > --- a/drivers/staging/ks7010/ks_wlan_net.c
> > +++ b/drivers/staging/ks7010/ks_wlan_net.c
> > @@ -423,7 +423,7 @@ static int ks_wlan_get_wap(struct
> net_device *dev, struct iw_request_info *info,
> >
> > ÂÂÂÂÂÂÂÂÂ/* for SLEEP MODE */
> > ÂÂÂÂÂÂÂÂÂif ((priv->connect_status & CONNECT_STATUS_MASK) ==
> CONNECT_STATUS)
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(awrq->sa_data,
> &(priv->current_ap.bssid[0]), ETH_ALEN);
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(awrq->sa_data, priv->current_ap.bssid,
> ETH_ALEN);
> > ÂÂÂÂÂÂÂÂÂelse
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂeth_zero_addr(awrq->sa_data);
> >
> > @@ -1364,7 +1364,7 @@ static int ks_wlan_get_aplist(struct
> net_device *dev,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn -EPERM;
> > ÂÂÂÂÂÂÂÂÂ/* for SLEEP MODE */
> > ÂÂÂÂÂÂÂÂÂfor (i = 0; i < priv->aplist.size; i++) {
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(address[i].sa_data,
> &(priv->aplist.ap[i].bssid[0]),
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemcpy(address[i].sa_data,
> &priv->aplist.ap[i].bssid[0],
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â Â ETH_ALEN);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂaddress[i].sa_family = ARPHRD_ETHER;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂqual[i].level = 256 -
> priv->aplist.ap[i].rssi;
> > @@ -1454,7 +1454,7 @@ static inline char
> *ks_wlan_translate_scan(struct net_device *dev,
> > ÂÂÂÂÂÂÂÂÂiwe.u.data.flags = 1;
> > ÂÂÂÂÂÂÂÂÂcurrent_ev =
> > ÂÂÂÂÂÂÂÂÂ Â Âiwe_stream_add_point(info, current_ev, end_buf,
> &iwe,
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ &(ap->ssid.body[0]));
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ap->ssid.body);
> >
> > ÂÂÂÂÂÂÂÂÂ/* Add mode */
> > ÂÂÂÂÂÂÂÂÂiwe.cmd = SIOCGIWMODE;
> > @@ -1496,7 +1496,7 @@ static inline char
> *ks_wlan_translate_scan(struct net_device *dev,
> > ÂÂÂÂÂÂÂÂÂiwe.u.data.length = 0;
> > ÂÂÂÂÂÂÂÂÂcurrent_ev =
> > ÂÂÂÂÂÂÂÂÂ Â Âiwe_stream_add_point(info, current_ev, end_buf,
> &iwe,
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ &(ap->ssid.body[0]));
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ap->ssid.body);
> >
> > ÂÂÂÂÂÂÂÂÂ/* Rate : stuffing multiple values in a single event
> require a bit
> > ÂÂÂÂÂÂÂÂÂ * more of magic - Jean II */
> > @@ -1612,7 +1612,7 @@ static int ks_wlan_get_scan(struct
> net_device *dev,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcurrent_ev = ks_wlan_translate_scan(dev,
> current_ev,
> > Â// Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âextra +
> IW_SCAN_MAX_DATA,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âextra +
> dwrq->length,
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â
> Â&(priv->current_ap));
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â
> Â&priv->current_ap);
> > ÂÂÂÂÂÂÂÂÂ}
> > Â#endif
> > ÂÂÂÂÂÂÂÂÂ/* Read and parse all entries */
> > @@ -1625,7 +1625,7 @@ static int ks_wlan_get_scan(struct
> net_device *dev,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcurrent_ev = ks_wlan_translate_scan(dev,
> info, current_ev,
> > Â// Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âextra +
> IW_SCAN_MAX_DATA,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âextra +
> dwrq->length,
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â
> Â&(priv->aplist.ap[i]));
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â
> Â&priv->aplist.ap[i]);
> > ÂÂÂÂÂÂÂÂÂ}
> > ÂÂÂÂÂÂÂÂÂ/* Length of data */
> > ÂÂÂÂÂÂÂÂÂdwrq->length = (current_ev - extra);
> > @@ -2080,7 +2080,7 @@ static int ks_wlan_set_pmksa(struct
> net_device *dev,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂbreak;
> > ÂÂÂÂÂÂÂÂÂcase IW_PMKSA_FLUSH:
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemset(&(priv->pmklist), 0,
> sizeof(priv->pmklist));
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂmemset(&priv->pmklist, 0,
> sizeof(priv->pmklist));
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂINIT_LIST_HEAD(&priv->pmklist.head);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfor (i = 0; i < PMK_LIST_MAX; i++)
> >
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂINIT_LIST_HEAD(&priv->pmklist.pmk[i].list);
> > @@ -2178,7 +2178,7 @@ static int
> ks_wlan_get_firmware_version(struct net_device *dev,
> > Â{
> > ÂÂÂÂÂÂÂÂÂstruct ks_wlan_private *priv =
> > ÂÂÂÂÂÂÂÂÂ Â Â(struct ks_wlan_private *)netdev_priv(dev);
> > -ÂÂÂÂÂÂÂÂstrcpy(extra, &(priv->firmware_version[0]));
> > +ÂÂÂÂÂÂÂÂstrcpy(extra, priv->firmware_version);
> > ÂÂÂÂÂÂÂÂÂdwrq->length = priv->version_size + 1;
> > ÂÂÂÂÂÂÂÂÂreturn 0;
> > Â}
> > @@ -2433,7 +2433,7 @@ static int ks_wlan_data_read(struct
> net_device *dev,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂread_length =
> priv->dev_size[priv->dev_count];
> >
> > ÂÂÂÂÂÂÂÂÂ/* Copy data */
> > -ÂÂÂÂÂÂÂÂmemcpy(extra, &(priv->dev_data[priv->dev_count][0]),
> read_length);
> > +ÂÂÂÂÂÂÂÂmemcpy(extra, &priv->dev_data[priv->dev_count][0],
> read_length);
> >
> > ÂÂÂÂÂÂÂÂÂspin_unlock(&priv->dev_read_lock);ÂÂÂÂÂÂÂÂ/* release
> spin lock */
> >
> > @@ -3254,7 +3254,7 @@ static int ks_wlan_netdev_ioctl(struct
> net_device *dev, struct ifreq *rq,
> >
> > ÂÂÂÂÂÂÂÂÂswitch (cmd) {
> > ÂÂÂÂÂÂÂÂÂcase SIOCIWFIRSTPRIV + 20:ÂÂÂÂÂÂÂÂ/*
> KS_WLAN_SET_STOP_REQ */
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂrc = ks_wlan_set_stop_request(dev, NULL,
> &(wrq->u.mode), NULL);
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂrc = ks_wlan_set_stop_request(dev, NULL,
> &wrq->u.mode, NULL);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂbreak;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ// All other calls are currently unsupported
> > ÂÂÂÂÂÂÂÂÂdefault:
> > --
> > 2.11.0
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an email to outreachy-kern...@xxxxxxxxxxxxxxxxx
> > To post to this group, send email to
> outreach...@xxxxxxxxxxxxxxxxx
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170220065310.GA21888%4
> 0arushi-HP-Pavilion-Notebook.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/f41dab07-08d8-4545-93fb-
> 88c9845767bb%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Next message: Dou Liyang: "[PATCH v2 0/4] Revert works for the mapping of cpuid <-> nodeid"
Previous message: Steve Twiss: "RE: [RESEND PATCH V5 7/8] thermal: da9062/61: Thermal junction temperature monitoring driver"
In reply to: Julia Lawall: "Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]