Re: [PATCH v8 2/2] Documentation/ABI: Add ABI information for QCOM socinfo driver

[Imran Khan]

On 2/18/2017 4:06 AM, Stephen Boyd wrote:
> On 01/10, Imran Khan wrote:
>> The socinfo ABI document describes the information provided
>> by socinfo driver and the corresponding attributes to access
>> that information.
>>
>> Signed-off-by: Imran Khan <kimran@xxxxxxxxxxxxxx>
>> ---
>>  Documentation/ABI/stable/sysfs-driver-qcom_socinfo | 147 +++++++++++++++++++++
> 
> Perhaps move it to testing instead of stable too?
> 
Done.

>>  1 file changed, 147 insertions(+)
>>  create mode 100644 Documentation/ABI/stable/sysfs-driver-qcom_socinfo
>>
>> diff --git a/Documentation/ABI/stable/sysfs-driver-qcom_socinfo b/Documentation/ABI/stable/sysfs-driver-qcom_socinfo
>> new file mode 100644
>> index 0000000..f90c142
>> --- /dev/null
>> +++ b/Documentation/ABI/stable/sysfs-driver-qcom_socinfo
>> @@ -0,0 +1,147 @@
>> +What:		/sys/devices/soc0/accessory_chip
>> +Date:		January 2017
>> +Description:
>> +		This file shows the id of the accessory chip.
> 
> Please add a contact, linux-arm-msm@xxxxxxxxxxxxxxx perhaps?
> 

Done. Added linux-arm-msm@xxxxxxxxxxxxxxx as contact.
>> +
>> +What:		/sys/devices/soc0/adsp_image_crm
>> +What:		/sys/devices/soc0/adsp_image_variant
>> +What:		/sys/devices/soc0/adsp_image_version
>> +Date:		January 2017
>> +Description:

<snip>

>> +What:		/sys/devices/soc0/pmic_die_revision
>> +Date:		January 2017
>> +Description:
>> +		This file shows revision of PMIC die.
>> +
>> +What:		/sys/devices/soc0/pmic_model
>> +Date:		January 2017
>> +Description:
>> +		This file shows name of PMIC model.
> 
> This doesn't seem very future proof when there's more than on
> pmic, and really pmic isn't part of the SoC so it's sort of odd
> to have that here in the first place. Any chance we can drop this
> for now?
> 
True. It needs some changes when there are more than one PMICs.
But right now I intend to show information about one PMIC and later
on add to that. For example right now we create sysfs attributes 
only after finding out that those attributes are supported in socinfo
version currently available. We can use the same approach for socinfo
versions that provide information about multiple PMICs. 
Accordingly I will change this document too.
Though PMIC is not part of SoC, but as this information is available
as a part of the same SMEM item, I wanted to make this information
available to user space.
Please let me know if it sounds okay with you?

Thanks and Regards,
Imran


-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a\nmember of the Code Aurora Forum, hosted by The Linux Foundation