Re: [PATCH v2] gpio: xgene: mark PM functions as __maybe_unused

From: Linus Walleij
Date: Thu Feb 23 2017 - 09:51:37 EST


On Fri, Feb 17, 2017 at 4:13 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions:
>
> drivers/gpio/gpio-xgene.c:155:12: warning: 'xgene_gpio_resume' defined but not used [-Wunused-function]
> static int xgene_gpio_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~
> drivers/gpio/gpio-xgene.c:142:12: warning: 'xgene_gpio_suspend' defined but not used [-Wunused-function]
> static int xgene_gpio_suspend(struct device *dev)
>
> The warnings are harmless and can be avoided by simplifying the code and marking
> the functions as __maybe_unused.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> v2: remove #ifdef around set_dr_val as well, to avoid build regression

Patch applied for fixes.

Yours,
Linus Walleij