Re: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as a level_high
From: Linus Walleij
Date: Thu Feb 23 2017 - 09:54:26 EST
On Fri, Feb 17, 2017 at 10:12 AM, Phil Reid <preid@xxxxxxxxxxxxxxxxx> wrote:
> ret = gpiochip_irqchip_add(&altera_gc->mmchip.gc, &altera_irq_chip, 0,
> - handle_simple_irq, IRQ_TYPE_NONE);
> + altera_gc->interrupt_trigger == IRQ_TYPE_LEVEL_HIGH ?
> + handle_level_irq : handle_simple_irq, IRQ_TYPE_NONE);
I would say: set it to handle_bad_irq() for everything and then set it
to handle_level_irq() or handle_simple_irq() in the .set_type() function
using the rq_set_handler_locked() callback like everyone else,
nicely reflecting the synthesized trigger type.
I think that would work?
Yours,
Linus Walleij