Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

From: Julia Lawall
Date: Fri Feb 24 2017 - 11:49:07 EST




On Fri, 24 Feb 2017, Arushi Singhal wrote:

>
>
> On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal wrote:
> > function prototype arguments like 'struct vb_device_info
> *','unsigned
> > long' etc. should have an identifier name.
> >
> > Signed-off-by: Arushi Singhal
> <arushisinghal19971997@xxxxxxxxx>
> > ---
> > Changes in v3:
> >Â Â- By mistake one irrelevant line was added which is removed
> in this
> >Â Â Âpatch.
> >Â Â- write the changes done in previous version in correct
> format.
> >Â Â- make the commit subject more relevant and accurate.
>
> This patch doesn't apply to my tree at all :(
>
> Why this is so?

Maybe someone else made a change on the same lines as yours. Check that
your tree is up to date.

julia

> thanks
> Arushi
> sorry,
>
> greg k-h
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF_sihk6_UhgLzUH6
> FVSFMu02Vadp1tjatQft-UJ14SJeA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>