Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

[Julia Lawall]

On Sat, 25 Feb 2017, Arushi Singhal wrote:

>
>
> On Fri, Feb 24, 2017 at 10:18 PM, Julia Lawall <julia.lawall@xxxxxxx> wrote:
>
>
>       On Fri, 24 Feb 2017, Arushi Singhal wrote:
>
>       >
>       >
>       > On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman
>       > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>       >Â Â Â ÂOn Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal
>       wrote:
>       >Â Â Â Â> function prototype arguments like 'struct
>       vb_device_info
>       >Â Â Â Â*','unsigned
>       >Â Â Â Â> long' etc. should have an identifier name.
>       >Â Â Â Â>
>       >Â Â Â Â> Signed-off-by: Arushi Singhal
>       >Â Â Â Â<arushisinghal19971997@xxxxxxxxx>
>       >Â Â Â Â> ---
>       >Â Â Â Â> Changes in v3:
>       >Â Â Â Â>Â Â- By mistake one irrelevant line was added which is
>       removed
>       >Â Â Â Âin this
>       >Â Â Â Â>Â Â Âpatch.
>       >Â Â Â Â>Â Â- write the changes done in previous version in
>       correct
>       >Â Â Â Âformat.
>       >Â Â Â Â>Â Â- make the commit subject more relevant and
>       accurate.
>       >
>       >Â Â Â ÂThis patch doesn't apply to my tree at all :(
>       >
>       > Why this is so?
>
>       Maybe someone else made a change on the same lines as yours.Â
>       Check that
>       your tree is up to date.
>
> Is all the changes being done by someone before?

I don't know.  Just update your tree and try to apply your patch again.
Or look at the code that your patch should apply to.  It should be easy to
see what is wrong.

julia

>
>       julia
>
>       > thanks
>       > Arushi
>       >Â Â Â Âsorry,
>       >
>       >Â Â Â Âgreg k-h
>       >
>       >
> > --
> > You received this message because you are subscribed to the Google
> Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an
> > email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> > To post to this group, send email to
> outreachy-kernel@xxxxxxxxxxxxxxxxx
> > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF_sihk6_Uhg
> LzUH6
> > FVSFMu02Vadp1tjatQft-UJ14SJeA%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF91bd_er%2BidvUB
> PZCTYFHaxF6Mgf1oQ6vTz9gmk6ggC6Q%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>