Re: [PATCH v1 0/4] gpio: make gpiod_count() API consistent

From: Benjamin Tissoires
Date: Mon Feb 27 2017 - 03:30:21 EST


On Feb 20 2017 or thereabouts, Andy Shevchenko wrote:
> There are three possibilities in gpiod_count(): ACPI, OF, and
> platform data.
>
> Some of them return 0, which requires to be handled separately, though
> developers rather lazy and just shadow an actual error code.
>
> Let's make this API consistent by not allowing 0 in returned value.
>
> There are luckily only 3 users right now, one of them handles this
> properly, the rest is converted in this series.
>
> Series is supposed to go through GPIO tree.
>
> Andy Shevchenko (4):
> gpio: acpi: Don't return 0 on acpi_gpio_count()
> gpio: of: Don't return 0 on dt_gpio_count()
> platform/x86: surface3_button: Propagate error from gpiod_count()
> Input: soc_button_array - Propagate error from gpiod_count()

Not sure if this still matters, but still:
Acked-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Cheers,
Benjamin

>
> drivers/gpio/gpiolib-acpi.c | 4 ++--
> drivers/gpio/gpiolib.c | 4 ++--
> drivers/input/misc/soc_button_array.c | 5 +++--
> drivers/platform/x86/surface3_button.c | 5 +++--
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
> --
> 2.11.0
>