Re: [PATCH 0/3] lib: add module support to sort tests
From: Andy Shevchenko
Date: Tue Feb 28 2017 - 09:32:43 EST
On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
> Hi Andrew,
>
> This patch series allows to compile the array-based and linked list
> sort
> test code either to loadable modules, or builtin into the kernel.
>
> It's very valuable to have modular tests, so you can run them just by
> insmodding the test modules, instead of needing a separate kernel that
> runs them at boot.
>
> Thanks for applying!
FWIW:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
On the first glance looks okay to me. I didn't carefully checked code
move (I guess -M -C will not help much, though one can play with numbers
there), so I believe Geert didn't change much there.
>
> Geert Uytterhoeven (3):
> Â Revert "lib/test_sort.c: make it explicitly non-modular"
> Â lib: add module support to array-based sort tests
> Â lib: add module support to linked list sorting tests
>
> Âlib/Kconfig.debugÂÂÂÂ|ÂÂ14 ++---
> Âlib/MakefileÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> Âlib/list_sort.cÂÂÂÂÂÂ| 149 ------------------------------------------
> --------
> Âlib/test_list_sort.c | 150
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> Âlib/test_sort.cÂÂÂÂÂÂ|ÂÂ11 ++--
> Â5 files changed, 164 insertions(+), 161 deletions(-)
> Âcreate mode 100644 lib/test_list_sort.c
>
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy