Re: [PATCH akpm v2] lib: test_sort: make it explicitly non-modular

[Paul Gortmaker]

[Re: [PATCH akpm v2] lib: test_sort: make it explicitly non-modular] On 28/02/2017 (Tue 12:43) Geert Uytterhoeven wrote:

> Hi Paul,
> 
> On Tue, Jan 24, 2017 at 11:56 PM, Paul Gortmaker
> <paul.gortmaker@xxxxxxxxxxxxx> wrote:
> > The Kconfig currently controlling compilation of this code is:
> >
> >      lib/Kconfig.debug:config TEST_SORT
> >      lib/Kconfig.debug:      bool "Array-based sort test"
> >
> > ...meaning that it currently is not being built as a module by anyone.
> >
> > Lets remove the couple traces of modular infrastructure use, so that
> > when reading the code there is no doubt it is builtin-only.
> >
> > Since module_init translates to device_initcall in the non-modular
> > case, the init ordering becomes slightly earlier when we change it
> > to use subsys_initcall as done here.  However, since it is a self
> > contained test, this shouldn't be an issue and subsys_initcall
> > seems like a better fit for this particular case.
> >
> > We also delete the MODULE_LICENSE tag since that information is now
> > contained at the top of the file in the comments.
> 
> Yeah, MODULE_LICENSE is too easy to grep for... :-(
> 
> > Cc: Kostenzer Felix <fkostenzer@xxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> 
> Can we please stop doing this?
> 

As I've said many times, I have no problem with things being modular if
there is a use case for it to be so.  And it makes sense to have that
demand driven.

What I'm striving for is consistency between the Kconfig and the source
code, and I'll continue to work on that.

Thanks,
Paul.
--

> It's very valuable to have modular tests, so you can run them just by
> insmodding the test, instead of needing a separate kernel that runs them
> at boot.
> 
> Will send a revert + modular enablement...
> 
> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds