[RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts

From: Roger Quadros
Date: Wed Mar 15 2017 - 09:53:18 EST


Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
phy_suspend() doesn't get called as part of phy_stop() for PHYs using
interrupts because the phy state machine is never triggered after a phy_stop().

Explicitly trigger the PHY state machine so that it can
see the new PHY state (HALTED) and suspend the PHY.

Signed-off-by: Roger Quadros <rogerq@xxxxxx>
---
drivers/net/phy/phy.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1be69d8..8fef03b 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -903,6 +903,7 @@ void phy_stop(struct phy_device *phydev)
* of rtnl_lock(), but PHY_HALTED shall guarantee phy_change()
* will not reenable interrupts.
*/
+ phy_trigger_machine(phydev, true);
}
EXPORT_SYMBOL(phy_stop);

--
2.7.4