Re: [PATCH] sched/fair: Fix ftq noise bench regression

[Dietmar Eggemann]

On 22/03/17 16:55, Vincent Guittot wrote:
> On 22 March 2017 at 17:22, Dietmar Eggemann <dietmar.eggemann@xxxxxxx> wrote:
>> On 22/03/17 09:22, Vincent Guittot wrote:
>>> On 21 March 2017 at 18:46, Dietmar Eggemann <dietmar.eggemann@xxxxxxx> wrote:
>>>> Hi Vincent,
>>>>
>>>> On 17/03/17 13:47, Vincent Guittot wrote:

[...]

>> +static inline bool blocked_update_needed(struct sched_entity *se)
>> +{
>> +       struct cfs_rq *gcfs_rq = group_cfs_rq(se);
> 
> gcfs_rq can't be set before testing that se is not null

Ah correct, but you could set it after the !se check.