Re: [PATCHv2 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD

[Richard Genoud]

2017-03-24 16:58 GMT+01:00 Rob Herring <robh@xxxxxxxxxx>:
> On Mon, Mar 20, 2017 at 02:32:22PM +0100, Richard Genoud wrote:
>> This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT
>> LCD panel, which can be supported by the simple panel driver.
>>
>> Signed-off-by: Richard Genoud <richard.genoud@xxxxxxxxx>
>> ---
>>
>> Changes since v1:
>> Add power-supply property and an example in documentation
>>
>>  .../bindings/display/panel/winstar,wf35ltiacd      | 53 ++++++++++++++++++++++
>>  drivers/gpu/drm/panel/panel-simple.c               | 28 ++++++++++++
>>  2 files changed, 81 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd
>> new file mode 100644
>> index 000000000000..9ff59b868b28
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/winstar,wf35ltiacd
>> @@ -0,0 +1,53 @@
>> +Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
>> +
>> +Required properties:
>> +- compatible: should be "winstar,wf35ltiacd"
>> +- power-supply: regulator to provide the VCC supply voltage (3.3 volts)
>> +
>> +This binding is compatible with the simple-panel binding, which is specified
>> +in simple-panel.txt in this directory.
>> +
>> +Example:
>> +     backlight: backlight {
>> +             compatible = "pwm-backlight";
>> +             pwms = <&hlcdc_pwm 0 50000 PWM_POLARITY_INVERTED>;
>> +             brightness-levels = <0 31 63 95 127 159 191 223 255>;
>> +             default-brightness-level = <191>;
>> +             power-supply = <&bl_reg>;
>> +             status = "okay";
>
> Drop status from examples.
>
>> +     };
>> +
>> +     bl_reg: backlight_regulator {
>> +             compatible = "regulator-fixed";
>> +             regulator-name = "backlight-power-supply";
>> +             regulator-min-microvolt = <5000000>;
>> +             regulator-max-microvolt = <5000000>;
>> +             status = "okay";
>> +     };
>> +
>> +     panel: panel {
>> +             compatible = "winstar,wf35ltiacd", "simple-panel";
>> +             backlight = <&backlight>;
>> +             power-supply = <&panel_reg>;
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             status = "okay";
>> +
>> +             port@0 {
>> +                     #address-cells = <1>;
>> +                     #size-cells = <0>;
>> +
>> +                     panel_input: endpoint@0 {
>> +                             reg = <0>;
>
> You don't need reg and unit-addresses for these.
>
> With that,
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>
Ok, I'll resend the patch with reg and unit-addresses removed.

Thanks !

>> +                             remote-endpoint = <&hlcdc_panel_output>;
>> +                     };
>> +             };
>> +     };
>> +
>> +     panel_reg: panel_regulator {
>> +             compatible = "regulator-fixed";
>> +             regulator-name = "panel-power-supply";
>> +             regulator-min-microvolt = <3300000>;
>> +             regulator-max-microvolt = <3300000>;
>> +             status = "okay";
>> +     };