Re: [PATCH 3/6] mm: remove return value from init_currently_empty_zone

From: Michal Hocko
Date: Fri Mar 31 2017 - 02:49:08 EST


On Fri 31-03-17 11:49:49, Hillf Danton wrote:
[...]
> > -/* Can fail with -ENOMEM from allocating a wait table with vmalloc() or
> > - * alloc_bootmem_node_nopanic()/memblock_virt_alloc_node_nopanic() */
> > -static int __ref ensure_zone_is_initialized(struct zone *zone,
> > +static void __ref ensure_zone_is_initialized(struct zone *zone,
> > unsigned long start_pfn, unsigned long num_pages)
> > {
> > - if (zone_is_empty(zone))
> > - return init_currently_empty_zone(zone, start_pfn, num_pages);
> > -
> > - return 0;
> > + if (!zone_is_empty(zone))
> > + init_currently_empty_zone(zone, start_pfn, num_pages);
> > }
> Semantic change added?

could you be more specific?
--
Michal Hocko
SUSE Labs