Re: [PATCH 1/6] mm: get rid of zone_is_initialized

From: Michal Hocko
Date: Fri Mar 31 2017 - 02:48:33 EST


On Fri 31-03-17 08:43:01, Michal Hocko wrote:
> On Fri 31-03-17 11:39:07, Hillf Danton wrote:
> >
> > On March 30, 2017 7:55 PM Michal Hocko wrote:
> > >
> > > @@ -5535,9 +5535,6 @@ int __meminit init_currently_empty_zone(struct zone *zone,
> > > zone_start_pfn, (zone_start_pfn + size));
> > >
> > > zone_init_free_lists(zone);
> > > - zone->initialized = 1;
> > > -
> > > - return 0;
> > > }
> > Nit: Add changes more than correct.
>
> I am sorry, I do not follow?

OK, got it. init_currently_empty_zone should be changed to void. Screw
up during the split of the initial patch. Will fix that up. Also
zone_spans_range should go to patch 5 because it doesn't have any user
until then.
--
Michal Hocko
SUSE Labs