Re: [PATCH] tcmu: Skip Data-Out blocks before gathering Data-In buffer for BIDI case

From: Nicholas A. Bellinger
Date: Sun Apr 02 2017 - 19:20:35 EST


On Fri, 2017-03-31 at 10:35 +0800, lixiubo@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Xiubo Li <lixiubo@xxxxxxxxxxxxxxxxxxxx>
>
> For the bidirectional case, the Data-Out buffer blocks will always at
> the head of the tcmu_cmd's bitmap, and before gathering the Data-In
> buffer, first of all it should skip the Data-Out ones, or the device
> supporting BIDI commands won't work.
>
> Fixed: 26418649eead ("target/user: Introduce data_bitmap, replace
> data_length/data_head/data_tail")
> Reported-by: Ilias Tsitsimpis <iliastsi@xxxxxxxxxxx>
> Signed-off-by: Xiubo Li <lixiubo@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/target/target_core_user.c | 48 +++++++++++++++++++++++++++------------
> 1 file changed, 33 insertions(+), 15 deletions(-)

Applied to target-pending/master, with a CC' to linux-4.6.y stable.

Thanks Xiubo + Ilias.