Re: [PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key

From: David Miller
Date: Wed Apr 05 2017 - 10:27:58 EST


From: Eric Biggers <ebiggers3@xxxxxxxxx>
Date: Mon, 3 Apr 2017 22:50:20 -0700

> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> Since commit d6580a9f1523 ("kexec: sysrq: simplify sysrq-c handler"),
> the sysrq handler for the 'c' key has been sysrq_crash_op. Debugging
> code in the ibm_emac driver also tries to register a handler for the 'c'
> key, but this has no effect because register_sysrq_key() doesn't replace
> existing handlers. Since evidently no one has cared enough to fix this
> in the last 8 years, and it's very rare for drivers to register sysrq
> handlers (for good reason), just remove the dead code.
>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Applied to net-next, thanks.