Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

[Vivien Didelot]

Hi Florian,

Florian Fainelli <f.fainelli@xxxxxxxxx> writes:

> On 04/11/2017 01:52 PM, Vivien Didelot wrote:
>> This patch moves as is the legacy DSA code from dsa.c to legacy.c,
>> except the few shared symbols which remain in dsa.c.
>> 
>> Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled,
>> which is true by default.
>> 
>> DSA drivers without legacy support don't need the probe function as well
>> as driver registration helpers anymore, so remove their definitions if
>> CONFIG_NET_DSA_LEGACY is disabled.
>> 
>> NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support.
>
> BCM_SF2 is not dependent on legacy support since it got converted to the
> new API in the past few months.

Oops, my bad. Fixing it.

> You may want to generate your patch with git format-patch -M to help
> detect renames/code movements.

I used --find-copies-harder -C for easier review but I can use -M.

Thanks,

        Vivien