Re: [PATCH 2/2] kbuild: fix asm-offset generation to work with clang

From: Matthias Kaehlcke
Date: Fri Apr 14 2017 - 13:45:04 EST


El Fri, Apr 14, 2017 at 02:50:03PM +0900 Masahiro Yamada ha dit:

> From: Jeroen Hofstee <jeroen@xxxxxxxxxxxxx>
>
> KBuild abuses the asm statement to write to a file and
> clang chokes about these invalid asm statements. Hack it
> even more by fooling this is actual valid asm code.
>
> Signed-off-by: Jeroen Hofstee <jeroen@xxxxxxxxxxxxx>
> [masahiro:
> Import Jeroen's work for U-Boot:
> http://patchwork.ozlabs.org/patch/375026/
> Tweak sed script a little to drop garbage '#' for GCC case, like
> #define NR_PAGEFLAGS 23 /* __NR_PAGEFLAGS # */ ]
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
Tested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>

I tested with x86 and arm64. Please note that two more changes are
needed to avoid breaking frv and um:

https://patchwork.kernel.org/patch/9660473/
https://patchwork.kernel.org/patch/9660503/

Maybe these should be part of your patch set? I only sent them out
separately to avoid cross posting with my initial patch for this issue
being a RFC.

Cheers

Matthias