Re: [PATCH] stmmac: Add support for SIMATIC IOT2000 platform

[Andy Shevchenko]

On Tue, Apr 25, 2017 at 1:09 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> On 2017-04-25 12:07, Jan Kiszka wrote:
>> On 2017-04-25 11:46, Andy Shevchenko wrote:
>>> On Tue, Apr 25, 2017 at 12:00 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>>>> On 2017-04-25 09:30, Andy Shevchenko wrote:
>>>>> On Tue, Apr 25, 2017 at 8:44 AM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>>>>>> On 2017-04-24 23:27, Andy Shevchenko wrote:
>>>>>>> On Mon, Apr 24, 2017 at 10:27 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:

>>>        {
>>>                .name = "SIMATIC IOT2000",
>>>                .func = 6,
>>>                .phy_addr = 1,
>>>        },
>>>        {
>>>                .name = "SIMATIC IOT2000",
>>>                .func = 7,
>>>                .phy_addr = 1,
>>>        },
>>>
>>> That's all what you need.
>>
>> Nope. Again: the asset tag is the way to tell both apart AND to ensure
>> that we do not match on future devices.

> To be more verbose: your version (which is our old one) would even
> enable the second, not connected port on the IOT2020. Incorrectly.

So, name has 2000 for 2020 device? It's clear bug in DMI table you have. :-(

What else do you have in DMI which can be used to distinguish those devices?

> Plus
> the risk to match different future devices.

-- 
With Best Regards,
Andy Shevchenko