Re: [PATCH v2] x86, msr: Document AMD "tweak MSRs", use MSR_FnnH_NAME scheme for them

[Borislav Petkov]

On Tue, Apr 25, 2017 at 06:15:23PM +0200, Denys Vlasenko wrote:
> On 04/25/2017 06:06 PM, Borislav Petkov wrote:
> > Pls no. Not every MSR for every family. Only the 4 which are actually
> > being used. We can't hold in here the full 32-bit MSR space.
> 
> The replacement of four define names is not the purpose
> of the proposed patch.
> 
> The patch was prompted by the realization that these particular MSRs
> are so badly and inconsistently documented that it takes many hours
> of work and requires reading of literally a dozen PDFs to figure out
> what are their names, which CPUs have them, and what bits are known.

They're all documented in the respective BKDGs or revision guides.

> Anyone who looks at only one document won't see the full picture.

And what is the big picture?

To me it is just a bunch of MSRs. What's so special about them?

> Patch does not document bits, but at least documents all MSR names
> and explains why documentation is so sparse.

No, we don't document MSRs in the kernel - we collect all the MSRs the
kernel uses in msr-index.h.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.