Re: [PATCH v2] x86, msr: Document AMD "tweak MSRs", use MSR_FnnH_NAME scheme for them
From: Denys Vlasenko
Date: Tue Apr 25 2017 - 12:49:01 EST
On 04/25/2017 06:23 PM, Borislav Petkov wrote:
On Tue, Apr 25, 2017 at 06:15:23PM +0200, Denys Vlasenko wrote:
On 04/25/2017 06:06 PM, Borislav Petkov wrote:
Pls no. Not every MSR for every family. Only the 4 which are actually
being used. We can't hold in here the full 32-bit MSR space.
The replacement of four define names is not the purpose
of the proposed patch.
The patch was prompted by the realization that these particular MSRs
are so badly and inconsistently documented that it takes many hours
of work and requires reading of literally a dozen PDFs to figure out
what are their names, which CPUs have them, and what bits are known.
They're all documented in the respective BKDGs or revision guides.
Yes. For some definition of "documented".
Let's say you are looking at all available documentation for Fam10h CPUs -
BKDG, Revision Guide, five volumes of APM, software optimization guide.
Eight documents.
If you read all of them, you can find exactly one mention that
MSR 0xC0011029 exists. It is mentioned by number.
As a reader of this documentation, can you find out what is it?
Does it have a name, at least?
You are right that kernel is not exactly the best place to store more info
about such things, but AMD probably won't accept my edits to their
documentation.