Re: [PATCH v7] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

From: David Herrmann
Date: Wed May 03 2017 - 07:14:59 EST


On Mon, May 1, 2017 at 9:47 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Sun, Apr 30, 2017 at 02:11:03PM +0900, Tomohiro Yoshidomi wrote:
>> PlayStation 1/2 joypads can be connected directly to the SPI interface.
>> Signed-off-by: Tomohiro Yoshidomi <sylph23k@xxxxxxxxx>
> Benjamin, David, I think this driver now matches the gamepad spec that
> we have in Drivers/input/gamepad.rst. Could you give it an one-over, as
> far as mappings go, otherwise I think it can be applied and merged with
> my 2nd pull request.

Looks good to me:

Acked-by: David Herrmann <dh.herrmann@xxxxxxxxx>

The FF code could be select'ed rather than conditional. Everything
else looks fine. I didn't check the SPI internals though. Never
touched SPI, sorry.