Re: [PATCH v7] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

[Tomohiro Yoshidomi]

Mr.Torokhov
Mr.Herrmann

> The FF code could be select'ed rather than conditional.

Sorry, I can't understand mean well. How I to do...?

I should to fix,

In 'config JOYSTICK_PSXPAD_SPI',
change 'select INPUT_POLLDEV' to
'select INPUT_POLLDEV
select INPUT_FF_MEMLESS'.

And

In 'config JOYSTICK_PSXPAD_SPI_FF',
remove 'select INPUT_FF_MEMLESS'.

...Can I understand in the sense?

Regard.


2017-05-03 20:14 GMT+09:00 David Herrmann <dh.herrmann@xxxxxxxxx>:
> Hey
>
> On Mon, May 1, 2017 at 9:47 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>> On Sun, Apr 30, 2017 at 02:11:03PM +0900, Tomohiro Yoshidomi wrote:
>>> PlayStation 1/2 joypads can be connected directly to the SPI interface.
>>>
>>> Signed-off-by: Tomohiro Yoshidomi <sylph23k@xxxxxxxxx>
>>
>> Benjamin, David, I think this driver now matches the gamepad spec that
>> we have in Drivers/input/gamepad.rst. Could you give it an one-over, as
>> far as mappings go, otherwise I think it can be applied and merged with
>> my 2nd pull request.
>
> Looks good to me:
>
> Acked-by: David Herrmann <dh.herrmann@xxxxxxxxx>
>
> The FF code could be select'ed rather than conditional. Everything
> else looks fine. I didn't check the SPI internals though. Never
> touched SPI, sorry.
>
> Thanks
> David