Re: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

[Bjorn Andersson]

On Wed, May 17, 2017 at 9:40 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not
> enabled (seen on x86_64).
>
> drivers/built-in.o: In function `sba_prep_dma_pq_req':
> (.text+0x16132): undefined reference to `raid6_gflog'
> drivers/built-in.o: In function `sba_prep_dma_pq_single_req':
> (.text+0x162f4): undefined reference to `raid6_gflog'
>
> This driver needs RAID6_PQ and MAILBOX (from inspection) independent of
> ARM64 or COMPILE_TEST.
>
> However, RAID6_PQ is not defined in any Kconfig file, although it is
> used in several of them. :(
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Anup Patel <anup.patel@xxxxxxxxxxxx>
> Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
> Cc: dmaengine@xxxxxxxxxxxxxxx

Hit this as well today.

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn