Re: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

From: Vinod Koul
Date: Thu May 18 2017 - 23:44:11 EST


On Wed, May 17, 2017 at 09:40:47AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not
> enabled (seen on x86_64).

Oops, I already applied one from Arnd and pushed that out.

>
> drivers/built-in.o: In function `sba_prep_dma_pq_req':
> (.text+0x16132): undefined reference to `raid6_gflog'
> drivers/built-in.o: In function `sba_prep_dma_pq_single_req':
> (.text+0x162f4): undefined reference to `raid6_gflog'
>
> This driver needs RAID6_PQ and MAILBOX (from inspection) independent of
> ARM64 or COMPILE_TEST.
>
> However, RAID6_PQ is not defined in any Kconfig file, although it is
> used in several of them. :(
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Anup Patel <anup.patel@xxxxxxxxxxxx>
> Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
> Cc: dmaengine@xxxxxxxxxxxxxxx
> ---
> drivers/dma/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20170517.orig/drivers/dma/Kconfig
> +++ linux-next-20170517/drivers/dma/Kconfig
> @@ -101,7 +101,8 @@ config AXI_DMAC
>
> config BCM_SBA_RAID
> tristate "Broadcom SBA RAID engine support"
> - depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST
> + depends on ARM64 || COMPILE_TEST
> + depends on MAILBOX && RAID6_PQ
> select DMA_ENGINE
> select DMA_ENGINE_RAID
> select ASYNC_TX_DISABLE_XOR_VAL_DMA
>
>

--
~Vinod