Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102

[Andy Shevchenko]

On Thu, May 18, 2017 at 3:31 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> On 2017-05-18 13:07, Andy Shevchenko wrote:
>> On Wed, May 17, 2017 at 6:28 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>>> This is an upstream port of an IIO driver for the TI ADC108S102 and
>>> ADC128S102. The former can be found on the Intel Galileo Gen2 and the
>>> Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is
>>> included.
>>>
>>> Due to the lack of regulators under ACPI, we hard-code the voltage
>>> provided to the VA pin of the ADC to 5 V, the value used on Galileo and
>>> IOT2000. For DT usage, the regulator "vref-supply" provides this
>>> information. Note that DT usage has not been tested.
>>>
>>> Original author: Bogdan Pricop <bogdan.pricop@xxxxxxxxxx>
>>> Ported from Intel Galileo Gen2 BSP to Intel Yocto kernel:
>>> Todor Minchev <todor@xxxxxxxxxxxxx>.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>>
>> It seems you missed my tag.
>>
>> FWIW:
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> As the code changed again, I left it out. Thanks for confirming it that
> it still applies!

Yes, it does with the same remark about regulator API usage.

-- 
With Best Regards,
Andy Shevchenko