Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

From: Viresh Kumar
Date: Thu May 18 2017 - 23:43:18 EST


On 18-05-17, 16:51, Arnd Bergmann wrote:
> I find that a lot of users get the #ifdef wrong, either using the wrong
> macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right
> set of functions (e.g. calling a function only from the suspend handler).
>
> The __maybe_unused annotation avoids both problems and also gives
> better build time coverage, so that's what I tend to use.

Thanks for the explanation Arnd. I hope these unused routines will not
be part of the binary that gets generated. Right?

Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh