Re: [PATCH v5 02/11] mm: mempolicy: add queue_pages_node_check()

[Zi Yan]

On 19 May 2017, at 16:28, Mel Gorman wrote:

> On Fri, May 19, 2017 at 12:37:38PM -0400, Zi Yan wrote:
>>> As you say, there is no functional change but the helper name is vague
>>> and gives no hint to what's it's checking for. It's somewhat tolerable as
>>> it is as it's obvious what is being checked but the same is not true with
>>> the helper name.
>>>
>>
>> Does queue_pages_invert_nodemask_check() work? I can change the helper name
>> in the next version.
>>
>
> Not particularly, maybe queue_pages_required and invert the check with a
> comment above it explaining what it's checking for would be ok.
>

queue_pages_required() is too broad, I would take queue_pages_page_nid_check()
and invert the check with a comment above saying

/*
 * Check if the page's nid is in qp->nmask.
 *
 * If MPOL_MF_INVERT is set in qp->flags, check if the nid is
 * in the invert of qp->nmask.
 */

Does it work?

--
Best Regards
Yan Zi

Attachment: signature.asc
Description: OpenPGP digital signature