Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush code

From: Nadav Amit
Date: Mon May 22 2017 - 19:24:33 EST


>
> /* Balance as user space task's flush, a bit conservative */
> if (end == TLB_FLUSH_ALL ||
> - (end - start) > tlb_single_page_flush_ceiling * PAGE_SIZE) {
> + (end - start) > tlb_single_page_flush_ceiling >> PAGE_SHIFT) {

Shouldnât it be << ?

Nadav