Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush code

[Andy Lutomirski]

On Mon, May 22, 2017 at 4:24 PM, Nadav Amit <nadav.amit@xxxxxxxxx> wrote:
>>
>>       /* Balance as user space task's flush, a bit conservative */
>>       if (end == TLB_FLUSH_ALL ||
>> -         (end - start) > tlb_single_page_flush_ceiling * PAGE_SIZE) {
>> +         (end - start) > tlb_single_page_flush_ceiling >> PAGE_SHIFT) {
>
> Shouldnât it be << ?

Gah, that's embarrassing.