Re: [PATCH 3/5] pinctrl: meson-gxbb: Add CEC pins

[Jerome Brunet]

On Wed, 2017-05-24 at 10:20 +0200, Neil Armstrong wrote:
> Add the AO and EE domain CEC pins for the Amlogic Meson GXBB SoCs.

The patch is correct but a slightly longer blurb would have been nice :)

Here AO and EE are not referring to the GPIO controller like they usually do in
our patches to pinctrl.
They refer to the 2 different CEC controllers, located in each power domain and
both connected to AO GPIO controller (same pin actually)

Not sure if this worth a resent though.

Reviewed-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

> 
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> ---
> Âdrivers/pinctrl/meson/pinctrl-meson-gxbb.c | 10 ++++++++++
> Â1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index 3ccb0f4f..b44314a 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -295,6 +295,9 @@
> Âstatic const unsigned int spdif_out_ao_6_pins[]	= { PIN(GPIOAO_6, 0)
> };
> Âstatic const unsigned int spdif_out_ao_13_pins[] = { PIN(GPIOAO_13, 0) };
> Â
> +static const unsigned int ao_cec_pins[]ÂÂÂÂÂÂÂÂÂÂ= { PIN(GPIOAO_12, 0) };
> +static const unsigned int ee_cec_pins[]ÂÂÂÂÂÂÂÂÂÂ= { PIN(GPIOAO_12, 0) };
> +
> Âstatic struct meson_pmx_group meson_gxbb_periphs_groups[] = {
> Â	GPIO_GROUP(GPIOZ_0, EE_OFF),
> Â	GPIO_GROUP(GPIOZ_1, EE_OFF),
> @@ -560,6 +563,8 @@
> Â	GROUP(i2s_out_ch45_ao,	1,	1),
> Â	GROUP(spdif_out_ao_6,	0,	16),
> Â	GROUP(spdif_out_ao_13,	0,	4),
> +	GROUP(ao_cec,ÂÂÂÂÂÂÂÂÂÂÂ0,ÂÂÂÂÂÂ15),
> +	GROUP(ee_cec,ÂÂÂÂÂÂÂÂÂÂÂ0,ÂÂÂÂÂÂ14),
> Â};
> Â
> Âstatic const char * const gpio_periphs_groups[] = {
> @@ -752,6 +757,10 @@
> Â	"spdif_out_ao_6", "spdif_out_ao_13",
> Â};
> Â
> +static const char * const cec_ao_groups[] = {
> +	"ao_cec", "ee_cec",
> +};
> +
> Âstatic struct meson_pmx_func meson_gxbb_periphs_functions[] = {
> Â	FUNCTION(gpio_periphs),
> Â	FUNCTION(emmc),
> @@ -793,6 +802,7 @@
> Â	FUNCTION(pwm_ao_b),
> Â	FUNCTION(i2s_out_ao),
> Â	FUNCTION(spdif_out_ao),
> +	FUNCTION(cec_ao),
> Â};
> Â
> Âstatic struct meson_bank meson_gxbb_periphs_banks[] = {