Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode

[Jiri Olsa]

On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote:

SNIP

> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 3041c6b98191..ffde0dafed6f 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -256,6 +256,14 @@ static int process_event_stub(struct perf_tool *tool __maybe_unused,
>  	return 0;
>  }
>  
> +static int process_feature_stub(struct perf_tool *tool __maybe_unused,
> +				union perf_event *event __maybe_unused,
> +				struct perf_session *session __maybe_unused)
> +{
> +	dump_printf(": unhandled!\n");
> +	return 0;
> +}
> +
>  static int process_finished_round_stub(struct perf_tool *tool __maybe_unused,
>  				       union perf_event *event __maybe_unused,
>  				       struct ordered_events *oe __maybe_unused)
> @@ -427,6 +435,8 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
>  		tool->stat_round = process_stat_round_stub;
>  	if (tool->time_conv == NULL)
>  		tool->time_conv = process_event_op2_stub;
> +	if (tool->feature == NULL)
> +		tool->feature = process_feature_stub;

no need to define new one, you can use process_event_op2_stub

jirka