Re: [PATCH v5 3/6] linux/bug.h: correct "(foo*)" should be "(foo *)"

From: Michal Nazarewicz
Date: Thu May 25 2017 - 09:59:43 EST


On Thu, May 25 2017, Ian Abbott wrote:
> Correct this checkpatch.pl error:
>
> |ERROR: "(foo*)" should be "(foo *)"
> |#19: FILE: include/linux/bug.h:19:
> |+#define BUILD_BUG_ON_NULL(e) ((void*)0)
>
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>
> Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> ---
> v5: Actually, there was no v1 thru v4. I called this v5 to match the
> series.
> ---
> include/linux/bug.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/bug.h b/include/linux/bug.h
> index ca24007e2dc3..216a1b79653d 100644
> --- a/include/linux/bug.h
> +++ b/include/linux/bug.h
> @@ -16,7 +16,7 @@ struct pt_regs;
> #define __BUILD_BUG_ON_NOT_POWER_OF_2(n) (0)
> #define BUILD_BUG_ON_NOT_POWER_OF_2(n) (0)
> #define BUILD_BUG_ON_ZERO(e) (0)
> -#define BUILD_BUG_ON_NULL(e) ((void*)0)
> +#define BUILD_BUG_ON_NULL(e) ((void *)0)
> #define BUILD_BUG_ON_INVALID(e) (0)
> #define BUILD_BUG_ON_MSG(cond, msg) (0)
> #define BUILD_BUG_ON(condition) (0)

--
Best regards
ããã âðððð86â ãããããã
ÂIf at first you donât succeed, give up skydivingÂ