Re: [PATCH 2/2] tick: Make sure tick timer is active when bypassing reprogramming

[Levin, Alexander (Sasha Levin)]

On Sat, Jun 03, 2017 at 02:42:43PM +0200, Frederic Weisbecker wrote:
> On Sat, Jun 03, 2017 at 08:06:41AM +0000, Levin, Alexander (Sasha Levin) wrote:
> > On Fri, Apr 21, 2017 at 04:00:55PM +0200, Frederic Weisbecker wrote:
> > > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> > > index 502b320..be7ca4d 100644
> > > --- a/kernel/time/tick-sched.c
> > > +++ b/kernel/time/tick-sched.c
> > > @@ -783,8 +783,13 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
> > >  	tick = expires;
> > >  
> > >  	/* Skip reprogram of event if its not changed */
> > > -	if (ts->tick_stopped && (expires == ts->next_tick))
> > > -		goto out;
> > > +	if (ts->tick_stopped && (expires == ts->next_tick)) {
> > > +		/* Sanity check: make sure clockevent is actually programmed */
> > > +		if (likely(dev->next_event <= ts->next_tick))
> > > +			goto out;
> > > +
> > > +		WARN_ON_ONCE(1);
> > > +	}
> > 
> > I seem to be hitting that in a KVM vm, even without load (sometimes
> > right after boot):
> 
> Ah, can you tell me which tree you were using? Is it tip/master?

Its next-20170601: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20170601&id=3ab334ebe84e0dfd1cc3ea2fe77f5ce4406f7370

> Can you give me its HEAD and your config file?

Attached config.

-- 

Thanks,
Sasha

Attachment: config-sasha.gz
Description: config-sasha.gz