Re: __user with scalar data types

From: Al Viro
Date: Mon Jun 19 2017 - 12:34:44 EST

On Mon, Jun 19, 2017 at 10:15:09AM -0600, Jordan Crouse wrote:

> Which raised a bikeshed debate over whether it is appropriate to mark a scalar
> type as __user. My opinion is that it is appropriate because __user should mark
> user memory regardless of the container.

What the hell? __user is a qualifier like const, volatile, etc. It's a property
of *pointer* *type*. Not some nebulous "marks userland memory" thing.

> I'm looking for opinions or semi-authoritative edicts to determine if we should
> either start changing our uapi headers or go off and try to figure out how to
> make sparse understand this particular usage.

Stop cargo-culting, please.