Re: [PATCH v2 3/3] hwmon: ltc2990: support all measurement modes

From: Guenter Roeck
Date: Wed Jun 28 2017 - 12:01:26 EST


On Wed, Jun 28, 2017 at 05:29:38PM +0200, Tom Levens wrote:
>
[ ... ]

> >
> >>Whatever happened to this patch though? It didn't make it to mainline,
> >>otherwise I'd have found it sooner...
> >>
> >I'll have to look it up, but I guess I didn't get an updated version.
>
> As far as I remember I had a working V3 of this patch, but it is entirely
> possible that it was never submitted as I have been busy with other projects
> recently. I'll dig it out and check that it is complete.
>
FWIW, I don't see it at
https://patchwork.kernel.org/project/linux-hwmon/list/?submitter=171225&state=*

Maybe you were waiting for a reply from Rob. Either case, it might make
sense to only provide valid modes, ie to abstract the mode bits from the
hardware, such as

0 - internal temp only
1 - Tr1
2 - V1
3 - V1-V2
4 - Tr2
5 - V3
6 - V3-V4
7 to 14 - per bit 0..2

Guenter