Re: [PATCH 0/3] kselftest build errors

[Fathi Boudra]

On 28 June 2017 at 17:21, Shuah Khan <shuah@xxxxxxxxxx> wrote:
> On 06/28/2017 02:30 AM, Fathi Boudra wrote:
>> On 23 June 2017 at 22:44, Shuah Khan <shuah@xxxxxxxxxx> wrote:
>>> On 06/23/2017 04:37 AM, Marcin Nowakowski wrote:
>>>> This patch series fixes build errors observed when building net, memfd, gpio and intel_pstate tests
>>>>
>>>> Marcin Nowakowski (3):
>>>>   selftests/{net,memfd}: fix undefined references to external libraries
>>>>   selftests/gpio: fix build error
>>>>   selftests/intel_pstate: fix undefined reference when building
>>>>
>>>>  tools/testing/selftests/gpio/Makefile         | 2 +-
>>>>  tools/testing/selftests/intel_pstate/Makefile | 2 +-
>>>>  tools/testing/selftests/memfd/Makefile        | 4 ++--
>>>>  tools/testing/selftests/net/Makefile          | 2 +-
>>>>  4 files changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>
>>> Hi Marcin,
>>>
>>> SeongJae Park sent me fixes for the memfd/net/intel_pstate problems
>>> last week. I pulled those in already.
>>>
>>> The gpio fix is something I need to look at closely to see if this is
>>> the way to go. I will get back to you on that.
>>
>> Any updates on the gpio fix? I've tested it and it works for me.
>>
>
> I haven't decided yet.

another alternative is to use realpath:
-GPIODIR := ../../../gpio
+GPIODIR := $(realpath ../../../gpio)

btw, this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=51c6bd7cbe0366b642d8ac90d98739c39ab091a9
should be reverted once the build error is addressed because they
shouldn't have been there in the first place due to lack of trailing
slash in the path.

> thanks,
> -- Shuah