Re: [PATCH 0/1] expand_downwards: don't require the gap if !vm_prev

From: Linus Torvalds
Date: Thu Jun 29 2017 - 14:21:26 EST


On Thu, Jun 29, 2017 at 8:19 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> Hmm. May be you misread this patch?

Ahh, yes. I'm ok with your patch.

That said, you did remove something extra: the comment about

/* Check that both stack segments have the same anon_vma? */

is actually still relevant wrt that VM_GROWSDOWN test. The issue is
that we could actually limit the VM_GROWSDOWN thing to only be ok with
merging with a previous vma only if it *really* was the same segment.

And I think we could do that by checking the anon-vma (or maybe the vm_offset?)

Linus