Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix

From: Andrew Lunn
Date: Thu Jun 29 2017 - 14:22:41 EST


On Thu, Jun 29, 2017 at 02:14:55PM -0400, David Miller wrote:
> From: Lin Yun Sheng <linyunsheng@xxxxxxxxxx>
> Date: Wed, 28 Jun 2017 17:13:09 +0800
>
> > This Patch Set add set_loopback in phy_driver and use it to setup loopback
> > when doing ethtool phy self_test.
>
> This doesn't apply cleanly to the net-next tree, please respin.

Hi David

This patchset still has issues. The first patch is O.K. to be
committed, but the second patch to the hns driver still has issues. I
suppose it makes the hns driver less broken, but it is still
broken. Is less broken a sufficient criteria for acceptance?

Andrew