Re: [PATCH v2] sched/pelt: fix false running accounting

From: Peter Zijlstra
Date: Tue Jul 04 2017 - 07:07:38 EST


On Tue, Jul 04, 2017 at 11:57:12AM +0200, Vincent Guittot wrote:
> On 4 July 2017 at 11:44, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > But but but, how can that happen? Should it not all be under the same
> > rq->lock and thus have only a single update_rq_clock() and thus be at
> > the same 'instant' ?
>
> idle_balance() unlock rq->lock before calling update_blocked_averages
> And update_blocked_averages() starts by calling update_rq_clock()

Ah indeed. Might want to clarify that point.