Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

From: Arend van Spriel
Date: Tue Jul 11 2017 - 04:58:38 EST

On 10-07-17 19:02, Russell Joyce wrote:
>> 1) I think most of it should be some cfg80211 shareable code.
> Iâm not sure exactly what you mean by this, could you please clarify?

What I think RafaÅ is saying is that it would be better to have this
code in cfg80211 so other drivers including mac80211 could use it.

>> 2) This "rxtx" while surely present in other places sounds like a
>> workaround for LED subsystem limitation. Maybe it's time to finally
>> rework LED triggers.
> I agree that itâs not an ideal way to do things, but I couldnât think of a
> better alternative. I think that having a combined trigger is useful though, for
> situations like using the single LED on a Raspberry Pi to show Wi-Fi activity.

Indeed. However, the LED subsystem could/should(?) take care of mapping
"rx" and "tx" triggers to the same LED.

I am happy to comment on your patch, but maybe you can first take a look
at the suggestion RafaÅ made above.