Re: [PATCH V1 3/3] pinctrl: qcom: spmi-gpio: Correct power_source range check

[Fenglin Wu]

On 7/13/2017 5:33 AM, Bjorn Andersson wrote:
> On Mon 12 Jun 23:16 PDT 2017, fenglinw@xxxxxxxxxxxxxx wrote:
>
> > From: Fenglin Wu <fenglinw@xxxxxxxxxxxxxx>
> >
> > Power source selection in DIG_VIN_CTL is indexed from 0, in the range
> > check it shouldn't be equal to the total number of power sources.
> >
> > Signed-off-by: Fenglin Wu <fenglinw@xxxxxxxxxxxxxx>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>
> This patch is unrelated to the other patches in the series, when this is
> the case it's better to send it on its own.
>
> Regards,
> Bjorn
Sure, I will send it as an independent patch.
> > ---
> >   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > index 581309d..1fd677c 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > @@ -500,7 +500,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
> >   			pad->is_enabled = false;
> >   			break;
> >   		case PIN_CONFIG_POWER_SOURCE:
> > -			if (arg > pad->num_sources)
> > +			if (arg >= pad->num_sources)
> >   				return -EINVAL;
> >   			pad->power_source = arg;
> >   			break;
> > --
> > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project.

--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.